Fixing broken (undefined behavior) ics.find_devices device_type filter#232
Open
pierreluctg wants to merge 1 commit into
Open
Fixing broken (undefined behavior) ics.find_devices device_type filter#232pierreluctg wants to merge 1 commit into
pierreluctg wants to merge 1 commit into
Conversation
…defined behavior) due to wrong array reset argument The fix changes `new unsigned int(device_types_list_size)` → `new unsigned int[device_types_list_size]`, so the allocation matches the `unique_ptr<unsigned int[]>` type and all subsequent `device_types_list[i]` accesses are valid. Fixes intrepidcs#231
Contributor
Author
|
FYI @drebbe-intrepid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call to ics.find_devices wit a device_type filter value is broken (undefined behavior) due to wrong array reset argument
The fix changes
new unsigned int(device_types_list_size)→new unsigned int[device_types_list_size], so the allocation matches theunique_ptr<unsigned int[]>type and all subsequentdevice_types_list[i]accesses are valid.Reference: https://en.cppreference.com/cpp/memory/unique_ptr/reset
Fixes #231